Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ondrap/master #75

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Ondrap/master #75

wants to merge 6 commits into from

Conversation

tmcgilchrist
Copy link
Contributor

@tmcgilchrist tmcgilchrist commented May 27, 2023 •
edited
Loading

Rebased version of #45.

Needs further evaluation of:

  1. the scanner dependency, should we pickup an additional dependency and is the package well enough maintained to choose.
  2. Run more benchmarks on recent GHC versions and compare against attoparsec

Benchmarks on macOS 12.6.3, GHC 8.10.7, 2.3 GHz Quad-Core Intel Core i7:

Running 1 benchmarks...
Benchmark bench: RUNNING...
benchmarking time encode/time/encode
time                 741.9 ns   (731.2 ns .. 751.0 ns)
                     0.999 R²   (0.999 R² .. 1.000 R²)
mean                 730.0 ns   (726.4 ns .. 736.7 ns)
std dev              15.80 ns   (10.20 ns .. 22.96 ns)
variance introduced by outliers: 27% (moderately inflated)

benchmarking time encode/thyme/encode
time                 353.7 ns   (350.0 ns .. 358.8 ns)
                     0.999 R²   (0.998 R² .. 0.999 R²)
mean                 358.7 ns   (354.5 ns .. 364.7 ns)
std dev              17.09 ns   (13.41 ns .. 21.56 ns)
variance introduced by outliers: 66% (severely inflated)

benchmarking time decode/time/decode
time                 1.465 μs   (1.462 μs .. 1.470 μs)
                     1.000 R²   (1.000 R² .. 1.000 R²)
mean                 1.465 μs   (1.463 μs .. 1.468 μs)
std dev              7.874 ns   (5.819 ns .. 10.35 ns)

benchmarking time decode/thyme/decode
time                 617.2 ns   (612.0 ns .. 624.1 ns)
                     1.000 R²   (0.999 R² .. 1.000 R²)
mean                 614.4 ns   (612.7 ns .. 618.0 ns)
std dev              8.069 ns   (3.528 ns .. 14.65 ns)
variance introduced by outliers: 12% (moderately inflated)

Benchmark bench: FINISH

@tmcgilchrist tmcgilchrist mentioned this pull request May 27, 2023
Closed
@tmcgilchrist
Add upper bound on Time.
27b3a0f 
Version 1.10 (2020-03-13), removed deprecated functions parseTime,
readTime, readsTime that are used in Thyme 3.6.
@tmcgilchrist
Copy link
Contributor Author

Trying 27b3a0f to isolate when Time library changed to find a cut-off version of a 3.7 compatibility release. https://github.com/haskell/time/blob/master/changelog.md?plain=1#L49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmcgilchrist @ondrap